Skip to content

Fix for bug 243#247

Closed
KostaIlic2 wants to merge 9 commits intoni:mainfrom
KostaIlic2:users/kosta/fix-bug-243
Closed

Fix for bug 243#247
KostaIlic2 wants to merge 9 commits intoni:mainfrom
KostaIlic2:users/kosta/fix-bug-243

Conversation

@KostaIlic2
Copy link
Contributor

What does this Pull Request accomplish?

Fix for bug 243.

Why should this Pull Request be merged?

Refer to the statement above.

What testing has been done?

I am leaning on CI automated tests.

…and introduced a new file.

Signed-off-by: Kosta Ilic <kosta.ilic@emerson.com>
- Conditionally skip test result publishing for forks to avoid permission errors
- Add informative message for fork PRs explaining the limitation
- Simplifies the approach while maintaining CI functionality

Signed-off-by: Kosta Ilic <kosta.ilic@emerson.com>
- Add event file upload to CI workflow for fork/dependabot support
- Create test_results.yml with workflow_run trigger for publishing results
- Remove report_test_results from CI as it's now handled by workflow_run
- This allows proper test result publishing for fork PRs without permission errors

Signed-off-by: Kosta Ilic <kosta.ilic@emerson.com>
- Revert to simpler approach that ensures status check always completes
- Use comment_mode: off for forks to avoid permission issues
- Split into two steps: one for forks (no comments) and one for main repo
- This ensures the 'Test Results' status check always gets reported

Signed-off-by: Kosta Ilic <kosta.ilic@emerson.com>
- Use comment_mode: off and minimal configuration
- Remove conditional logic that may not work in workflow_call context
- Ensure the action always runs with if: always()
- This should resolve status check hanging issues

Signed-off-by: Kosta Ilic <kosta.ilic@emerson.com>
- Add workflow context debugging to identify issues
- Add action_fail: false to prevent workflow failure
- Add final completion step to ensure workflow always completes
- This will help diagnose why status check is hanging

Signed-off-by: Kosta Ilic <kosta.ilic@emerson.com>
- Remove all custom parameters to use defaults
- Let the action handle fork detection internally
- This tests if the issue is with our configuration

Signed-off-by: Kosta Ilic <kosta.ilic@emerson.com>
- Use github-script to create exactly 'Test Results' status check
- This matches what the PR is expecting and should resolve hanging
- Simplified the status creation logic

Signed-off-by: Kosta Ilic <kosta.ilic@emerson.com>
- Add actions: read and issues: read permissions to PR workflow
- These may be required for the report_test_results workflow to function
- Should allow the Test Results check to be created properly on PRs

Signed-off-by: Kosta Ilic <kosta.ilic@emerson.com>
@KostaIlic2 KostaIlic2 closed this Jan 4, 2026
@KostaIlic2
Copy link
Contributor Author

Abandoning the PR.

@KostaIlic2 KostaIlic2 deleted the users/kosta/fix-bug-243 branch January 4, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant